@laeubi

The service segment has been incremented twice in this release cycle:

The @since in this PR is not okay because this was added for 2.10.200 not for 2.10. So we really should increase this to 2.11.0.

Also the package constraint where this constant is used says 2.2.0 because that's the current version of the package, but that version hasn't changed here and so that version of the package does not necessary have the public constant. So probably that should be increased too, probably to 2.11.0 like the bundle.

@merks I think the package should become 2.3.0 now according to semver as this is a client compatible change and I don't see why it must be aligned with the bundle version (what we didn't do before).

Since I'm just trying to resolve the reference issue in general, I've added the isEnabled changes to this PR. If you prefer, I can split it up into two PRs.

I've bumped p2.engine to 2.3.0 from 2.2.0. I'm holding off on the 2.11 story until consensus is achieved. Personally, I expect that 2.11 bundle is necessary, but that a 2.3 package suffices.

I've bumped p2.engine to 2.3.0 from 2.2.0. I'm holding off on the 2.11 story until consensus is achieved. Personally, I expect that 2.11 bundle is necessary, but that a 2.3 package suffices.

I’m good with that.

Test Results

    9 files  ±0      9 suites  ±0   30m 35s ⏱️ +9s
2 196 tests ±0  2 192 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 678 runs  ±0  6 667 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 8c2cddd. ± Comparison against base commit 0e4707e.

@tivervac thanks for the imropvement.